NOT TESTED!

- bugfix with ADAP
- FLOAT() to REAL() in lima_adjust*
- bugfix budget in rain_ice_elec
- others = minors or comments

mesonh/micro/rain_ice.f90 -> mesonh/micro/rain_ice_old.f90
mesonh/micro/rain_ice_red.f90 -> mesonh/micro/rain_ice.f90
bugfix for the new condensation interface
interface harmonisation betwwen mesonh/micro/rain_ice_red.f90 and arome/micro/rain_ice.F90

- lines too long
- missing & in ifdef REPRO48
- remove ,& in pointer association
- change of ASSOCIATE subroutine

- modd_budget : create TBUDGETCONF_t type and LBUDGET_* as POINTER
- ice_adjust_elec, lima_adjust_split : comment CALL CONDENSATION for the moment
- ini_rain_ice_elec : move allocation of variables to rain_ice_allocate (except XGAMINC_RIM3 not coded yet in modd_rain_ice_param (==>TODO for elec ?)
- mode_fill_dimphyexn : missing USE MODE_ll for GET_INDICE_ll
- resolved_cloud : use of CST_t + add new args for ICE_ADJUST (YLDIMPHYEX,CST, RAIN_ICE_PARAM,NEB, TBUCONF + LMFCONV)

Is the call of FILL_DIMPHYEX in resolved_cloud correct ?

Fields not bit_repro : THS_CLD, RVS_CLD, RCS_CLD, CLDFR

But is it really not surprising ?

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

Some merging
Move some modules in aux directory

- modi_condensation : remove MODD_SPP_TYPE (not used)
- condensation : fill HALO (NaN present) of PRC,PRV,PRI (OUT) with IN values (should be only on HALO instead of full copy) ==> on GPU branch, NaN should not trigg an exception in ice_adjust on the test of ZW1< 0.0  (SR)
+ PT computation on KIB:KIE only (because ZFRAC is defined on physical point only) in the CALL COMPUTE_FRAC_ICE
- modi/ice_adjust, condensation : move the TBUDGETS/KBUDGETS args (non optional possible) before the optionnal args
- mode_icecloud : modi_tiwmx was removed and the QSATMX_TAB is now in MODE_QSATMW_TAB
- lima_adjust_split, : SIGQSAT is now 2D

modd_* modified to enable execution with ifort
Phasing of modifications to enable PRFR option

nucleation optimised
docs/TODO updated

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

OCND2 included in common code (from AROME version)
OCND2 specific code moved in common/micro or arome/dead_code directories
High/Low cloud included for condensation (from Méso-NH version)
Harmonie SPP code moved outside of physics
condensation and ice_adjust optimised by Ryad
compute_frac_ice as an elemental procedure

Quentin 14/02/2022: Merge from main commit fef9ac31 + correct use of MODE in ini_ice_c1r3 + ini_param_elec

bugfix for bit-repro of mesonh test case from commit main a1e7305d

Adaptation of mode_ice4_compute_pdf
Revisit of nucleation

Some merging
Move some modules in aux directory

Modules transformed into structures (rain_ice_param, rain_ice_descr, param_ice)
Both sedimentations are done
rain_ice main routine is done
Nucleation routines are done (using an elemental function)

Structures for modd_cst, modd_budget, modd_neb and modd_rain_ice_param
New structure for array dimensions

OCND2 included in common code (from AROME version)
OCND2 specific code moved in common/micro or arome/dead_code directories
High/Low cloud included for condensation (from Méso-NH version)
Harmonie SPP code moved outside of physics
condensation and ice_adjust optimised by Ryad
compute_frac_ice as an elemental procedure

The 3 routines are merged into mode_compute_frac_ice
using optimisation (with pointers) developped by Ryad.

Merge arome rain_ice with:
- Ryad's versio: optimisation, KPROMA blocs
- Meso-NH version: subgrid precipiation
Arome aux:
- mode_ll to provide get_indice_ll
- mode_budget

Known issues:
- Bug around KPROMA blocs: results are different when used
- precipitation fraction cannot be used as long as condensation is not merged
- mode_ice4_sedimentation_momentum is still not plugged