For GPU, ice4_nucleation cannot be put in an include file
as included subroutine must not contain local variables.

mesonh/micro/rain_ice.f90 -> mesonh/micro/rain_ice_old.f90
mesonh/micro/rain_ice_red.f90 -> mesonh/micro/rain_ice.f90
bugfix for the new condensation interface
interface harmonisation betwwen mesonh/micro/rain_ice_red.f90 and arome/micro/rain_ice.F90

Quentin 13/04/2022: bugfix infinite loop sedimentation init inner values of ZREMAINT (bug in mesonh only)

- lines too long
- missing & in ifdef REPRO48
- remove ,& in pointer association
- change of ASSOCIATE subroutine

Original code contained a bug (autoconversion ri->rs was not set
to 0 if ldsoft when ri content gets lower than the threshold).
Introducing REPRO48 in ice4_slow allows to suppress the one
introduced in compute_pdf to compensate.

Simpler array declaration
ITPL initialisation
Cp computed using rain

REPRO48 key added in aro_adjust
PA/PB size declaration changed in ice4_tendencies (to allow bound checking)

Small modifications in ice_adjust and condensation

CMICRO variable passed to turb
REPRO48/REPRO55 used (instead of #ifndef REK) in sedimentation_stat

PCOMPUTE/ZCOMPUTE replaced by logical array
Last where statement decorated with mnh_expand

Arrays declared with KPROMA size

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size
WHERE statement decorated with mnh_expand directives

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size
WHERE statement decorated with mnh_expand directives

Hail and graupel (with ICE4 option) budgets was wrong in the initial commit and different,
but still wrong, in the previsous commit.
Bug correction in fast_rh protected by a REPRO48 macro

Hail and graupel (with ICE4 option) budgets was wrong in the initial commit and different,
but still wrong, in the previsous commit.
Bug correction in fast_rh protected by a REPRO48 macro

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size
WHERE statement decorated with mnh_expand directives

use of REPRO55 for mode_ice4_sedimentation_stat.F90 (in addition to REPRO48)

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

Merge of shallow_mf (Meso-NH version taken as reference)
Suppression of arome/chem/module/mod?_*.mod files
Bug correction in condensation +1 => -KKL
Bug correction in ice4_sedimentation_stat around PRPFR init to 0.

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

mode_compute_frac_ice becomes an include file which must be used
in contains section of subroutines through an #include or a fortran
INCLUDE

Suppression of ZMASK (DO with IF tests)
Arrays declared with KPROMA size
WHERE statement decorated with mnh_expand directives

All modd_* replaceed by structures in ICE3

- modi_condensation : remove MODD_SPP_TYPE (not used)
- condensation : fill HALO (NaN present) of PRC,PRV,PRI (OUT) with IN values (should be only on HALO instead of full copy) ==> on GPU branch, NaN should not trigg an exception in ice_adjust on the test of ZW1< 0.0  (SR)
+ PT computation on KIB:KIE only (because ZFRAC is defined on physical point only) in the CALL COMPUTE_FRAC_ICE
- modi/ice_adjust, condensation : move the TBUDGETS/KBUDGETS args (non optional possible) before the optionnal args
- mode_icecloud : modi_tiwmx was removed and the QSATMX_TAB is now in MODE_QSATMW_TAB
- lima_adjust_split, : SIGQSAT is now 2D

modd_* modified to enable execution with ifort
Phasing of modifications to enable PRFR option

nucleation optimised
docs/TODO updated

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

OCND2 included in common code (from AROME version)
OCND2 specific code moved in common/micro or arome/dead_code directories
High/Low cloud included for condensation (from Méso-NH version)
Harmonie SPP code moved outside of physics
condensation and ice_adjust optimised by Ryad
compute_frac_ice as an elemental procedure

Suppress error message in ice4_tendencies for PRFR option as
it is redundant with the message in rain_ice

Modification to reproduce old results with the PRFR option

Adaptation of mode_ice4_compute_pdf
Revisit of nucleation

Merge of shallow_mf (Meso-NH version taken as reference)
Suppression of arome/chem/module/mod?_*.mod files
Bug correction in condensation +1 => -KKL
Bug correction in ice4_sedimentation_stat around PRPFR init to 0.

Modules transformed into structures (rain_ice_param, rain_ice_descr, param_ice)
Both sedimentations are done
rain_ice main routine is done
Nucleation routines are done (using an elemental function)

Structures for modd_cst, modd_budget, modd_neb and modd_rain_ice_param
New structure for array dimensions

mode_compute_frac_ice becomes an include file which must be used
in contains section of subroutines through an #include or a fortran
INCLUDE

OCND2 included in common code (from AROME version)
OCND2 specific code moved in common/micro or arome/dead_code directories
High/Low cloud included for condensation (from Méso-NH version)
Harmonie SPP code moved outside of physics
condensation and ice_adjust optimised by Ryad
compute_frac_ice as an elemental procedure