- modi_condensation : remove MODD_SPP_TYPE (not used)
- condensation : fill HALO (NaN present) of PRC,PRV,PRI (OUT) with IN values (should be only on HALO instead of full copy) ==> on GPU branch, NaN should not trigg an exception in ice_adjust on the test of ZW1< 0.0  (SR)
+ PT computation on KIB:KIE only (because ZFRAC is defined on physical point only) in the CALL COMPUTE_FRAC_ICE
- modi/ice_adjust, condensation : move the TBUDGETS/KBUDGETS args (non optional possible) before the optionnal args
- mode_icecloud : modi_tiwmx was removed and the QSATMX_TAB is now in MODE_QSATMW_TAB
- lima_adjust_split, : SIGQSAT is now 2D

RIETTE Sébastien authored 3 years ago and RODIER Quentin committed 3 years ago

OCND2 included in common code (from AROME version)
OCND2 specific code moved in common/micro or arome/dead_code directories
High/Low cloud included for condensation (from Méso-NH version)
Harmonie SPP code moved outside of physics
condensation and ice_adjust optimised by Ryad
compute_frac_ice as an elemental procedure

Quentin 15/02/2022: Merge rain_ice_red : compile OK but not bit-repro. Move budget (not optional) args + adapt call rain_ice_red in resolved_cloud

Quentin 14/02/2022: Merge from main commit fef9ac31 + correct use of MODE in ini_ice_c1r3 + ini_param_elec

Quentin 11/02/2022: Merge from commit 538ca2b7 + modify variables ZA_* and ZB_* into a 2D variables ZA and ZB (as in arome/micro/rain_ice.F90)

This reverts commit 20f0d482.

bugfix for bit-repro of mesonh test case from commit main a1e7305d

Arome aux:
- modd_dimn.f90
- modd_blowsnow.F90
- modd_gridn.F90
- modd_metricsn.F90
- modd_ref.F90
- modd_turbn.F90
- modd_frc.F90
- modd_oceanh.F90

- mode_gather_ll.F90 with ABORT
- modi_second_mnh.F90

prandtl.F90 is added in existing mode_prandtl.F90

- REPRO48 used for TH Budget (dissipation term TKE ==> TH) was not present in AROME (bug)
- Problem remaining : Budgets terms TP,TR,DP has changed names

Arome aux:
 - get_halo.F90
 - argslist_ll for LIST_ll, ADD3DFIELD_ll, CLEANLIST_ll
 - modd_field.F90 for type TFIELDDATA (MesoNH I/O)
 - mode_io_field_write.F90 for IO_FIELD_WRITE subroutine
 - mode_ll.F90 : add UPDATE_HALO_ll
 - mode_io.F90 : add type TFILEDATA (MesoNH I/O)

 Known issues:
 - Budgets merged, it compiles but crashes at run
 - mesonh subroutine calls (turb, tke_eps_sources) not adapted (see new optionnal args)

The 3 routines are merged into mode_compute_frac_ice
using optimisation (with pointers) developped by Ryad.

Merge arome rain_ice with:
- Ryad's versio: optimisation, KPROMA blocs
- Meso-NH version: subgrid precipiation
Arome aux:
- mode_ll to provide get_indice_ll
- mode_budget

Known issues:
- Bug around KPROMA blocs: results are different when used
- precipitation fraction cannot be used as long as condensation is not merged
- mode_ice4_sedimentation_momentum is still not plugged